Conversation
ChangesCountMap is a map with source as key and state changes count as value. Fixes: w3c#226
anssiko
requested changes
Aug 14, 2023
index.html
Outdated
| <li> | ||
| a <dfn>[[\ChangesCountMap]]</dfn> integer set as part of the [=reset observation window=] steps. | ||
| a <dfn>[[\ChangesCountMap]]</dfn> [=ordered map=], [=map/keyed=] on a {{PressureSource}}, | ||
| representing the [=source type=] to which the last state change belongs. |
Member
There was a problem hiding this comment.
Would this proposed alternative wording mean the same:
representing the [=source type=] that triggered transition to the [=current pressure state=].
If that makes sense, then on L385 how about this wording:
representing the [=source type=] of the last {{PressureRecord}}.
(Disclaimer: I read this PR without additional context just trying make those lines read more like English, so this may not be what you try to specify.)
Contributor
Author
There was a problem hiding this comment.
ok, Thanks I ll make the change!
kenchris
reviewed
Aug 14, 2023
index.html
Outdated
| a <dfn>[[\ChangesCountMap]]</dfn> integer set as part of the [=reset observation window=] steps. | ||
| a <dfn>[[\ChangesCountMap]]</dfn> [=ordered map=], [=map/keyed=] on a {{PressureSource}}, | ||
| representing the [=source type=] to which the last state change belongs. | ||
| The [=ordered map=]'s [=map/value=] is an integer representing the count of state changes in the |
kenchris
approved these changes
Aug 14, 2023
anssiko
approved these changes
Aug 16, 2023
Member
anssiko
left a comment
There was a problem hiding this comment.
Approved with a grammar improvement suggestion.
index.html
Outdated
| a <dfn>[[\ChangesCountMap]]</dfn> integer set as part of the [=reset observation window=] steps. | ||
| a <dfn>[[\ChangesCountMap]]</dfn> [=ordered map=], [=map/keyed=] on a {{PressureSource}}, | ||
| representing the [=source type=] that triggered transition to the [=current pressure state=]. | ||
| The [=ordered map=]'s [=map/value=] is an integer representing the amount of state changes in the |
Member
There was a problem hiding this comment.
s/amount of state changes/number of state changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangesCountMap is a map with source as key
and state changes count as value.
Fixes: #226
Preview | Diff