Merged
Conversation
Related to #275, where it is explained that the current model of activating data delivery again when a document becomes fully active is unclear. Furthermore, doing the same thing to workers based on whether they are active needed workers or not does not have precedent in other specs and it is not clear if the current steps even work or not. Instead, do the following: - Remove the steps that handle a document becoming fully active again and point to #275. - Remove the steps that handle a worker becoming an active needed worker again for symmetry (and also because it is not clear if it _can_ become an active worker again once it it stops being so). - Merge the "Handle unloading document and closing of workers" section into the "Handling change of fully active" one. - For documents, the former was basically duplicating the latter. In fact, the "unloading document cleanup steps" are how specs are supposed to react to a document no longer being fully active. - For workers, the "active needed worker" references have been replaced by a check for the value of the `closing` flag in WorkerGlobalScope. - Use proper algorithm steps instead of prose to outline the steps that must be performed in both cases.
66c00f5 to
33d8962
Compare
kenchris
approved these changes
Jun 4, 2024
rakuco
pushed a commit
that referenced
this pull request
Jun 4, 2024
… list Follow-up to #276: use `|relevantGlobal|` in the Document fully active checks just like we do in the workers section right after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #275, where it is explained that the current model of activating
data delivery again when a document becomes fully active is unclear.
Furthermore, doing the same thing to workers based on whether they are
active needed workers or not does not have precedent in other specs and it
is not clear if the current steps even work or not.
Instead, do the following:
point to Properly determine bfcache integration strategy #275.
again for symmetry (and also because it is not clear if it can become an
active worker again once it it stops being so).
the "Handling change of fully active" one.
the "unloading document cleanup steps" are how specs are supposed to
react to a document no longer being fully active.
a check for the value of the
closingflag in WorkerGlobalScope.be performed in both cases.
Preview | Diff