Correction: Use null instead of NaN when stationary#173
Merged
Conversation
This ammends the existing correction clarifying the units and conditions for the heading property. This matches existing implementations which return null in this scenario.
marcoscaceres
approved these changes
Aug 14, 2024
reillyeon
added a commit
to reillyeon/content
that referenced
this pull request
Aug 14, 2024
Matches specification change in w3c/geolocation#173 and discussion about existing implementations in w3c/geolocation#171.
github-actions bot
added a commit
that referenced
this pull request
Aug 14, 2024
SHA: 9d5829e Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Aug 15, 2024
SHA: 9d5829e Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Josh-Cena
pushed a commit
to mdn/content
that referenced
this pull request
Aug 24, 2024
* Remove reference to NaN heading value Matches specification change in w3c/geolocation#173 and discussion about existing implementations in w3c/geolocation#171. * Update heading/index.md as well
4 tasks
2 tasks
Member
|
With the new Web Driver API, it's now possible to test this, so created: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ammends the existing correction clarifying the units and conditions for the heading property. This matches existing implementations which return null in this scenario.
Closes #171.
The following tasks have been completed:
Implementation commitment (and no objections):
Documentation (new feature):
Updated implementation reportAdded example to README or specFor documentation, either create an issue or pull request in MDN's Content repo - providing as much information as you can. PR is prefered.
Preview | Diff