Merged
Conversation
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Member
|
Pretty sure that a microtask can only be queued in the context of a task. When you're in parallel you have to queue a task. |
Member
Author
|
@annevk, ok, I was a bit unsure. I'll queue a task, but was unsure what task source to go with... should I mint a new one for geolocation? Or do you have a suggestion for an existing one? |
Member
Author
|
Gave this some thought... as every browser has its own dedicated location service manager, I'm going to mint a "geolocation task source". |
Member
Author
|
@annevk, added the new "geolocation task source" 🥫. |
Member
|
Seems reasonable. You want to use "queue a global task" and probably pass "this's relevant global object" (that you put in a variable before going in parallel). |
reillyeon
reviewed
Jun 15, 2021
marcoscaceres
commented
Jun 15, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
@annevk, I did as you suggested:
As I had to re-indent the algorithm, probably best viewed in PR-Preview.
Preview | Diff