Skip to content

Rewrite installation process and install prompting logic #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgiuca merged 14 commits into from
Sep 26, 2019
+130 −105
Merged

Rewrite installation process and install prompting logic #790

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f9f49e4
Rewrote install prompts and installation process.
mgiuca Sep 9, 2019
7732d3a
Fix usage of in parallel.
mgiuca Sep 12, 2019
d5a01d7
Clarify that install prompt may only be shown if the document is inst…
mgiuca Sep 12, 2019
3a9683c
Clarify that the user agent doesn't *have* to make the document insta…
mgiuca Sep 12, 2019
89cde75
s/non-installable/not installable
mgiuca Sep 12, 2019
f31386c
Move "or" to the next line.
mgiuca Sep 12, 2019
7fc9389
Use fancy respec syntax
mgiuca Sep 12, 2019
37cda87
More small fixes.
mgiuca Sep 12, 2019
eba0b45
Tidy.
mgiuca Sep 12, 2019
39bf682
Abbreviation UI now shows the correct expanded text.
mgiuca Sep 12, 2019
5aa3e1e
Normalize how we link to present an install prompt.
mgiuca Sep 12, 2019
f420481
Replace comment with a tracking issue number.
mgiuca Sep 12, 2019
1c4ff86
Respec stuff.
mgiuca Sep 26, 2019
7b0b5d7
Reorder parallel steps for clarity.
mgiuca Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move "or" to the next line. 
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
  • Loading branch information
@mgiuca @marcoscaceres
mgiuca and marcoscaceres authored Sep 12, 2019
commit f31386ceb446e3999125953fa73935e285ebdd6b
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ <h2>
user-agent-specific way (e.g., setting
<var>manifest</var>.<a data-link-for="WebAppManifest">`name`</a> to
the document <a data-cite="HTML#the-title-element">`title`</a>) and
considering the document <a>installable</a>, or
considering the document <a>installable</a>.
</li>
<li>Consider the document non-<a>installable</a>.
</li>
Expand Down