Fix ICE bad port test in WebRTC#45339
Merged
dontcallmedom merged 2 commits intoweb-platform-tests:masterfrom May 30, 2024
Merged
Fix ICE bad port test in WebRTC#45339dontcallmedom merged 2 commits intoweb-platform-tests:masterfrom
dontcallmedom merged 2 commits intoweb-platform-tests:masterfrom
Conversation
The test used onicestatechange instead of oniceconnectionstatechange. Also now runs on the full list of bad ports for completeness (thus requiring a long timeout)
Contributor
Author
|
@alvestrand paging you since that was originally your test. In particular, Chromium seems to fail this on ports starting at 1719 in the bad port list |
alvestrand
approved these changes
May 30, 2024
Contributor
alvestrand
left a comment
There was a problem hiding this comment.
I think this test is righter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test used onicestatechange instead of oniceconnectionstatechange. Also now runs on the full list of bad ports for completeness (thus requiring a long timeout)