build: use pre-commits to lint the lib#237
Conversation
|
Nice, I’m in favour of this, but maybe replace isort and black with ruff? |
|
I wasn't aware of ruff, let me update the config and run it again |
|
@maartenbreddels on the ruff readme they suggest to replace
should I go in this direction ? |
|
Let’s see what Mario thinks |
|
Looks good to me! Thanks! Regarding ruff, I don't know much about it, but if the authors recommend not replacing black, I'd go with that. |
mariobuikhuizen
left a comment
There was a problem hiding this comment.
Thanks for this contribution @12rambau!
Could you remove the package-lock files? (the changes are probably caused by using a different version of nodejs)
After that, can you squash the commits? I think this change can be one commit.
|
I rollback to the previous version of the package-lock files and removed ".vscode" from the I didn't squash anything from my side as I don't think the intermediate commits are meaningful. Could you instead squash it directly using the merge button? side advantage, you'll be able to select the commit message (I'm never sure if I'm using the appropriate conventional commit classifier) PS: please do that for any of my PR (we are doing the same in pydata-sphinx-theme and that gives nice changelog and easy to follow commit history). |
|
Yeah, I can do that 👍 , but I thought you might want to write the commit message and have the commit on your name. |
|
the commit will still be on my name no worries, and you can use the title of the PR (I've chosen it to be used as such) |
I added a .pre-commit config file to lint the lib using the following tools:
I also took the liberty to add 2 badges, and some configuration in the
setup.cfgFix #191