Skip to content

Expose ComponentInputBindingOptions in public API#67767

Merged
leonsenft merged 2 commits intoangular:mainfrom
SkyZeroZx:update-router-docs
Mar 24, 2026
Merged

Expose ComponentInputBindingOptions in public API#67767
leonsenft merged 2 commits intoangular:mainfrom
SkyZeroZx:update-router-docs

Conversation

@SkyZeroZx
Copy link
Copy Markdown
Contributor

@SkyZeroZx SkyZeroZx commented Mar 19, 2026 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from JeanMeche March 19, 2026 19:55
@SkyZeroZx SkyZeroZx changed the title Update router docs Expose ComponentInputBindingOptions in public API Mar 19, 2026
@angular-robot angular-robot bot added area: docs Related to the documentation area: router labels Mar 19, 2026
@ngbot ngbot bot modified the milestone: Backlog Mar 19, 2026
JeanMeche
JeanMeche reviewed Mar 19, 2026
View reviewed changes
packages/router/src/index.ts
InMemoryScrollingOptions,
ROUTER_CONFIGURATION,
RouterConfigOptions,
ComponentInputBindingOptions,
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

JeanMeche
JeanMeche approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api, fw-general, angular-dev

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 24, 2026
@ngbot
Copy link
Copy Markdown

ngbot bot commented Mar 24, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@leonsenft leonsenft merged commit 5879f31 into angular:main Mar 24, 2026
28 of 31 checks passed
@leonsenft
Copy link
Copy Markdown
Contributor

leonsenft commented Mar 24, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@SkyZeroZx SkyZeroZx deleted the update-router-docs branch March 24, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: router target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@SkyZeroZx @leonsenft @JeanMeche