fix(core): add 'object' to SRC_RESOURCE_TAGS for stricter URL sanitization#67780
Closed
ZeroXJacks wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): add 'object' to SRC_RESOURCE_TAGS for stricter URL sanitization#67780ZeroXJacks wants to merge 1 commit intoangular:mainfrom
ZeroXJacks wants to merge 1 commit intoangular:mainfrom
Conversation
Added 'object' tag to SRC_RESOURCE_TAGS for improved sanitization.
This comment was marked as outdated.
This comment was marked as outdated.
alan-agius4
requested changes
Mar 23, 2026
Contributor
alan-agius4
left a comment
There was a problem hiding this comment.
This change isn't quite right. As object does doesn't have a src attribute. I am doing some additional security hardning in #67797 and I'll handle this case too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
<object data="...">element can load external executable resourcessimilar to
<iframe src="/deoxy?target=https%3A%2F%2Fredirect.github.com%2Fangular%2Fangular%2Fpull%2F...">and<embed src="/deoxy?target=https%3A%2F%2Fredirect.github.com%2Fangular%2Fangular%2Fpull%2F...">, but it was missingfrom
SRC_RESOURCE_TAGSinsanitization.ts.This caused
getUrlSanitizer()to use the weakerɵɵsanitizeUrlinsteadof the stricter
ɵɵsanitizeResourceUrlfor<object>elements.Fix
Added
'object'toSRC_RESOURCE_TAGSso that bindings like<object [attr.data]="url">are treated as resource URLs andsanitized accordingly.
Related
embed,iframe, andscriptare handled