[vitest-pool-workers] Fix JSON require() in module fallback#11917
Merged
vicb merged 4 commits intocloudflare:mainfrom Jan 26, 2026
Merged
[vitest-pool-workers] Fix JSON require() in module fallback#11917vicb merged 4 commits intocloudflare:mainfrom
vicb merged 4 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 93cacb2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
penalosa
reviewed
Jan 20, 2026
Contributor
penalosa
left a comment
There was a problem hiding this comment.
Thank you for this PR! It's looking good, just a couple of questions about comments and testing
Contributor
There was a problem hiding this comment.
Thank you for adding this test! However, I think it might be more appropriate as a fixture test importing a real library that suffers from this (e.g. mime-types) in fixtures/vitest-pool-workers-examples/module-resolution/src/index.ts. Happy to add this if you'd like
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
vicb
reviewed
Jan 21, 2026
vicb
reviewed
Jan 21, 2026
- Use { json } module type directly instead of converting to ESM
- Replace synthetic test with mime-types fixture test in module-resolution
- Update example package in comment from Ajv to mime-types
f4364f3 to
c43ef1a
Compare
penalosa
approved these changes
Jan 23, 2026
Contributor
|
Thanks for the PR @ksawaneh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9822.
@cloudflare/vitest-pool-workers's module fallback service returned.jsonfiles ascommonJsModulesource. When a CommonJS dependency doesrequire("./data.json"),workerdwould try to parse the JSON as JavaScript and throwSyntaxError: Unexpected token ':'.This change:
.json.jsonas an ES module wrapper that exportsJSON.parse(...)(avoids object-literal__proto__prototype mutation)@cloudflare/vitest-pool-workersCommands run:
pnpm checkpnpm --filter @cloudflare/vitest-pool-workers run check:lintpnpm --filter @cloudflare/vitest-pool-workers run check:typepnpm exec vitest run test/json-require.test.ts(frompackages/vitest-pool-workers)Public documentation
A picture of a cute animal (not mandatory, but encouraged)
/_/
( o.o )