Skip to content

Handle shutdown sockets#2171

Merged
bluejekyll merged 1 commit intohickory-dns:mainfrom
dlon:handle-shutdown-sockets
Mar 16, 2024
Merged

Handle shutdown sockets#2171
bluejekyll merged 1 commit intohickory-dns:mainfrom
dlon:handle-shutdown-sockets

Conversation

@dlon
Copy link
Copy Markdown
Contributor

@dlon dlon commented Mar 12, 2024

Fix #2169. The server stops accepting connections if this fails due to an unrecoverable error. The list of "unrecoverable" errors might not be exhaustive.

djc
djc reviewed Mar 12, 2024
View reviewed changes
@dlon dlon force-pushed the handle-shutdown-sockets branch from b156b1c to 1cb319e Compare March 12, 2024 12:54
@djc
Copy link
Copy Markdown
Member

djc commented Mar 12, 2024

Did you remove all the TCP handling stuff? I think that would still be good to keep.

@dlon dlon force-pushed the handle-shutdown-sockets branch from 1cb319e to 8d8c8d0 Compare March 13, 2024 09:30
@dlon
Copy link
Copy Markdown
Contributor Author

dlon commented Mar 13, 2024

Did you remove all the TCP handling stuff? I think that would still be good to keep.

Done. I skipped quic and h3 since they don't seem to forward any meaningful error.

bluejekyll
bluejekyll approved these changes Mar 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR!

@bluejekyll bluejekyll merged commit d2e64d8 into hickory-dns:main Mar 16, 2024
@faern
Copy link
Copy Markdown
Contributor

faern commented Mar 22, 2024

Would it be possible to have a patch release with this fix in it published? The socket closing cause us significant issues. For now we depend on the git repository, but we want to depend on a crates.io release if possible 🙏

@dlon dlon deleted the handle-shutdown-sockets branch March 22, 2024 18:59
@djc
Copy link
Copy Markdown
Member

djc commented Apr 4, 2024

Sorry for the slow respons -- @bluejekyll seems to be very busy right now -- not sure if he will be able to publish to crates.io (or give me access, maybe via a GitHub team)? If so we can probably make this happen.

@djc
Copy link
Copy Markdown
Member

djc commented Apr 12, 2024 •
edited
Loading

Hey @faern -- sorry for the delay in getting back to you. Apparently we should be able to release from the Actions workflow if I tag a release, so I can (try) to do it after all. Can you try a backport PR?

I've pushed a release/0.24 branch which the PR can target which I started from the v0.24.0 tag. Feel free to include any semver-compatible commits in your branch.

@djc djc mentioned this pull request Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc left review comments

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle sockets that have been shut down

4 participants

@dlon @djc @faern @bluejekyll