Skip to content

gh-105090: Replace incorrect TLSv1.2 with TLSv1.3#105404

Merged
pablogsal merged 4 commits intopython:mainfrom
pandaninjas:patch-1
Jul 22, 2023
Merged

gh-105090: Replace incorrect TLSv1.2 with TLSv1.3#105404
pablogsal merged 4 commits intopython:mainfrom
pandaninjas:patch-1

Conversation

@pandaninjas
Copy link
Contributor

@pandaninjas pandaninjas commented Jun 6, 2023 •
edited by github-actions bot
Loading

The ssl doc specifies that it will only allow >=TLSv1.2, while the code actually only allows TLSv1.3

📚 Documentation preview 📚: https://cpython-previews--105404.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
Closed
@ghost
Copy link

ghost commented Jun 6, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

systematicguy
systematicguy approved these changes Jul 22, 2023
View reviewed changes
Copy link

@systematicguy systematicguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have also looked for other potential occurrences in the whole file, but none found.
I have done this review during the EuroPython 2023 sprints.

@pablogsal pablogsal added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 22, 2023
@pablogsal pablogsal enabled auto-merge (squash) July 22, 2023 14:29
@pablogsal pablogsal merged commit e5252c6 into python:main Jul 22, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2023

Thanks @pandaninjas for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2023

Sorry @pandaninjas and @pablogsal, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e5252c6127ad788b39221982964f935bd1513028 3.12

@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2023

GH-107038 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@pandaninjas @miss-islington
pythongh-105090: Replace incorrect TLSv1.2 with TLSv1.3 (pythonGH-105404
a7bf257 
)

(cherry picked from commit e5252c6)

Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2023

GH-107039 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 22, 2023
@pablogsal pablogsal removed the needs backport to 3.12 only security fixes label Jul 22, 2023
@pablogsal pablogsal added the needs backport to 3.12 only security fixes label Jul 22, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2023

Thanks @pandaninjas for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

pablogsal pushed a commit that referenced this pull request Jul 22, 2023
@miss-islington @pandaninjas
[3.11] gh-105090: Replace incorrect TLSv1.2 with TLSv1.3 (GH-105404) (#…
755166e 
…107038)

Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2023

GH-107040 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@pandaninjas @miss-islington
pythongh-105090: Replace incorrect TLSv1.2 with TLSv1.3 (pythonGH-105404
16ed6f4 
)

(cherry picked from commit e5252c6)

Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
pablogsal pushed a commit that referenced this pull request Jul 22, 2023
@miss-islington @pandaninjas
[3.10] gh-105090: Replace incorrect TLSv1.2 with TLSv1.3 (GH-105404) (#…
a9e5e59 
…107039)

Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
pablogsal pushed a commit that referenced this pull request Jul 22, 2023
@miss-islington @pandaninjas
[3.12] gh-105090: Replace incorrect TLSv1.2 with TLSv1.3 (GH-105404) (#…
c8a0296 
…107040)

Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@pandaninjas @miss-islington
pythongh-105090: Replace incorrect TLSv1.2 with TLSv1.3 (pythonGH-105404
5374833 
)

(cherry picked from commit e5252c6)

Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
This was referenced Dec 19, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

+1 more reviewer

@systematicguy systematicguy systematicguy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pablogsal pablogsal

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pandaninjas @miss-islington @bedevere-bot @pablogsal @systematicguy